feat: Add ruff linter and formatter for Python #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
approved these changes
May 29, 2024
mofojed
requested changes
Jun 2, 2024
| } | ||
|
|
||
| async handleSaveFromShortcut(): Promise<void> { | ||
| await this.handleFormat(); |
There was a problem hiding this comment.
I don't think we should auto format on save by default unless the user has opted in, configured the formatting settings, or has otherwise been notified this will be occurring. Imposing our preferred formatting settings on others without their approval is likely to annoy people.
I know this is going into a feature branch, but I think important to call that out.
There was a problem hiding this comment.
I commented this out for now and added a TODO comment to check if the user enabled format on save.
You can still format from the overflow menu on this branch
5 tasks
mofojed
approved these changes
Jun 6, 2024
mattrunyon
merged commit 2bf15a9
into
deephaven:feature/python-formatter
10 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the linter/formatter, but does not add user configuration yet. So I created a feature branch for it.
This is lazy loaded and only loaded if there is a Python monaco instance. You can verify by looking for wasm files in the network tab.
One thing to note is since embed-widget has its own copy of everything, I believe there would be 2 copies of the wasm in DHC which is not great.