Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NewTableColumnTypes class to @deephaven/jsapi-utils #2239

Closed
bmingles opened this issue Sep 27, 2024 · 0 comments · Fixed by #2244
Closed

Move NewTableColumnTypes class to @deephaven/jsapi-utils #2239

bmingles opened this issue Sep 27, 2024 · 0 comments · Fixed by #2244
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link
Contributor

The NewTableColumnTypes class currently lives in @deephaven/console. It seems to be similar to other jsapi related table constants defined in @deephaven/jsapi-utils TableUtils. As-is, any consumer wanting to use the class takes on all of the additional dependencies of @deephaven/console (including React Spectrum + other UI code). Specifically @deephaven-enterprise/query-utils depends on this class but has no need of UI libraries or any other console related things. We should move this class.

@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Sep 27, 2024
@vbabich vbabich added this to the October 2024 milestone Oct 1, 2024
@vbabich vbabich removed the triage Issue requires triage label Oct 1, 2024
@vbabich vbabich closed this as completed in 92b133b Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants