Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moved NewTableColumnTypes to jsapi-utils #2244

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Oct 3, 2024

Moved NewTableColumnTypes to jsapi-utils

resolves #2239

@bmingles bmingles requested review from a team and vbabich and removed request for a team October 3, 2024 14:36
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.42%. Comparing base (d2c6eab) to head (48de556).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2244   +/-   ##
=======================================
  Coverage   46.42%   46.42%           
=======================================
  Files         698      698           
  Lines       38761    38761           
  Branches     9801     9863   +62     
=======================================
  Hits        17993    17993           
  Misses      20714    20714           
  Partials       54       54           
Flag Coverage Δ
unit 46.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbabich vbabich merged commit 92b133b into deephaven:main Oct 3, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@bmingles bmingles deleted the 2239-move-new-table-column-types branch October 3, 2024 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move NewTableColumnTypes class to @deephaven/jsapi-utils
2 participants