Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console scrolls on 1st code block run #2275

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.61%. Comparing base (b552282) to head (c9196b7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/console/src/Console.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   46.61%   46.61%   -0.01%     
==========================================
  Files         696      696              
  Lines       38756    38757       +1     
  Branches     9891     9891              
==========================================
  Hits        18067    18067              
- Misses      20635    20636       +1     
  Partials       54       54              
Flag Coverage Δ
unit 46.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 marked this pull request as ready for review October 31, 2024 17:51
@wusteven815 wusteven815 requested review from a team and bmingles and removed request for a team October 31, 2024 17:51
@@ -401,6 +401,7 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {
return;
}

this.scrollConsoleHistoryToBottom();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always scroll to the bottom after any command run. It should only scroll if it was already at the bottom I think. Unless we want to change that behavior, but would need Don to approve a new behavior

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like we already scroll to bottom when a command starts, so this is probably fine

@mattrunyon mattrunyon dismissed their stale review October 31, 2024 18:04

Not needed

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I verified the behavior is fixed and it properly scrolls to the bottom when running a long script on clean console.

@wusteven815 wusteven815 merged commit 1fe8172 into deephaven:main Nov 1, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@wusteven815 wusteven815 deleted the 2207-console-scroll branch November 15, 2024 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console stuck to bottom does not stick to bottom on first code block run
3 participants