-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: console scrolls on 1st code block run #2275
Conversation
wusteven815
commented
Oct 30, 2024
- Fixes Console stuck to bottom does not stick to bottom on first code block run #2207
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
- Coverage 46.61% 46.61% -0.01%
==========================================
Files 696 696
Lines 38756 38757 +1
Branches 9891 9891
==========================================
Hits 18067 18067
- Misses 20635 20636 +1
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -401,6 +401,7 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> { | |||
return; | |||
} | |||
|
|||
this.scrollConsoleHistoryToBottom(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always scroll to the bottom after any command run. It should only scroll if it was already at the bottom I think. Unless we want to change that behavior, but would need Don to approve a new behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like we already scroll to bottom when a command starts, so this is probably fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I verified the behavior is fixed and it properly scrolls to the bottom when running a long script on clean console.