Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console scrolls on 1st code block run #2275

Merged
merged 1 commit into from
Nov 1, 2024
+1 −0
Merged

fix: console scrolls on 1st code block run #2275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/console/src/Console.tsx
View file
Original file line number Diff line number Diff line change
@@ -401,6 +401,7 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {
return;
}

this.scrollConsoleHistoryToBottom();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always scroll to the bottom after any command run. It should only scroll if it was already at the bottom I think. Unless we want to change that behavior, but would need Don to approve a new behavior

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like we already scroll to bottom when a command starts, so this is probably fine

this.updateHistory(result, newHistoryItem);
this.updateKnownObjects(newHistoryItem);
this.updateWorkspaceHistoryItem(