Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update version info pop-up with python/groovy version #2291

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Nov 12, 2024

Fixes #2184
Fixes #2289

Updates from tooltip to contextual help button, adds python/grrovy version and changes OS name to "User Agent OS" to clarify that it is the user agent reported version (and thus may be different from what you expect).

@dsmmcken dsmmcken requested a review from mofojed November 12, 2024 16:27
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (8ccab6d) to head (89c56c5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/code-studio/src/settings/SettingsMenu.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2291   +/-   ##
=======================================
  Coverage   46.62%   46.62%           
=======================================
  Files         702      702           
  Lines       38937    38940    +3     
  Branches     9717     9720    +3     
=======================================
+ Hits        18153    18156    +3     
  Misses      20773    20773           
  Partials       11       11           
Flag Coverage Δ
unit 46.62% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsmmcken dsmmcken merged commit a273b07 into main Nov 12, 2024
11 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_versions_help branch November 12, 2024 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS version listed by the IDE is incorrect Include Python/Groovy version info in the Web UI
2 participants