Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Worker plugin definitions, optional panel wrapper for Dashboards #1329

Merged
merged 5 commits into from
May 31, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented May 29, 2023

  • Fix up some types for plugins
  • Fix up some packaging
  • Add an optional panel wrapper to Dashboard

- Allows consumer of Dashboard to pass in a wrapper component type that can wrap each panel
  - Will be handy for giving each panel different contexts for APIs
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1329 (ded3748) into main (99818a8) will increase coverage by 0.00%.
The diff coverage is 16.66%.

@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   45.94%   45.94%           
=======================================
  Files         493      493           
  Lines       34410    34412    +2     
  Branches     8581     8582    +1     
=======================================
+ Hits        15811    15812    +1     
- Misses      18548    18549    +1     
  Partials       51       51           
Flag Coverage Δ
unit 45.94% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/app-utils/src/plugins/PluginUtils.tsx 22.38% <0.00%> (ø)
packages/dashboard/src/Dashboard.tsx 89.36% <ø> (ø)
packages/dashboard/src/DashboardLayout.tsx 47.32% <50.00%> (+0.04%) ⬆️

@mofojed mofojed changed the title fix: Worker plugin definitions fix: Worker plugin definitions, optional panel wrapper for Dashboards May 30, 2023
@mofojed mofojed requested a review from vbabich May 30, 2023 12:53
@mofojed mofojed self-assigned this May 30, 2023
@mofojed mofojed marked this pull request as ready for review May 30, 2023 12:53
@mofojed mofojed merged commit c32ffbc into deephaven:main May 31, 2023
@mofojed mofojed deleted the fix-worker-plugin-defs branch May 31, 2023 12:59
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants