Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent drag for webkit #1518

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Sep 15, 2023

Closes #1360

  • Repeated mouse move action to reliably trigger drag over event

From the Playwright docs: https://playwright.dev/docs/input#dragging-manually

If your page relies on the dragover event being dispatched, you need at least two mouse moves to trigger it in all browsers. To reliably issue the second mouse move, repeat your mouse.move() or locator.hover() twice. The sequence of operations would be: hover the drag element, mouse down, hover the drop element, hover the drop element second time, mouse up.

image

@ethanalvizo ethanalvizo self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (32e6d20) 46.42% compared to head (8e23b3f) 46.41%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   46.42%   46.41%   -0.01%     
==========================================
  Files         558      556       -2     
  Lines       35706    35718      +12     
  Branches     8917     8923       +6     
==========================================
+ Hits        16576    16580       +4     
- Misses      19080    19088       +8     
  Partials       50       50              
Flag Coverage Δ
unit 46.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethanalvizo ethanalvizo requested a review from mofojed September 15, 2023 17:25
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

tests/utils.ts Show resolved Hide resolved
@ethanalvizo ethanalvizo enabled auto-merge (squash) September 25, 2023 19:58
@ethanalvizo ethanalvizo requested a review from mofojed September 25, 2023 20:11
@ethanalvizo ethanalvizo merged commit cd5408c into deephaven:main Sep 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright drag not working if operation is too quick on webkit
2 participants