Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panel focus throwing an exception #1609

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Nov 1, 2023

  • Just pass the instance of Panel in if componentPanel is null
  • We'll need to do something else to wire up tables to linker

- Just pass the instance of Panel in if componentPanel is null
- We'll need to do something else to wire up tables to linker
@mofojed mofojed requested a review from mattrunyon November 1, 2023 00:11
@mofojed mofojed self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a260842) 46.68% compared to head (3d26d09) 46.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   46.68%   46.67%   -0.02%     
==========================================
  Files         583      583              
  Lines       36267    36255      -12     
  Branches     9074     9073       -1     
==========================================
- Hits        16933    16921      -12     
  Misses      19282    19282              
  Partials       52       52              
Flag Coverage Δ
unit 46.67% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../dashboard-core-plugins/src/WidgetLoaderPlugin.tsx 100.00% <ø> (ø)
...ckages/dashboard-core-plugins/src/panels/Panel.tsx 69.67% <100.00%> (-0.77%) ⬇️
.../dashboard-core-plugins/src/panels/WidgetPanel.tsx 54.23% <ø> (ø)
packages/dashboard/src/DashboardPlugin.ts 18.18% <ø> (ø)
packages/dashboard/src/layout/LayoutUtils.ts 13.94% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 9e8b7ae into deephaven:main Nov 2, 2023
5 checks passed
@mofojed mofojed deleted the 1604-component-panel branch November 2, 2023 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants