fix: Plugins were re-registering on every re-render

[mofojed]

• Forgot dependency array for useEffect hook

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (787c542) 46.68% compared to head (3631732) 46.68%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1613   +/-   ##
=======================================
  Coverage   46.68%   46.68%           
=======================================
  Files         583      583           
  Lines       36267    36267           
  Branches     9074     9074           
=======================================
  Hits        16930    16930           
  Misses      19285    19285           
  Partials       52       52           

Flag	Coverage Δ
unit	46.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../dashboard-core-plugins/src/WidgetLoaderPlugin.tsx	100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattrunyon]

Didn't realize the linter doesn't catch the case where you accidentally omit the dependency array

[mofojed]

Didn't realize the linter doesn't catch the case where you accidentally omit the dependency array

Yea same. I don't know if this behaviour changed in React or in our linter? Without the dependency array, it re-runs every render.