Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: theme fontawesome icon size wrapped in spectrum icons #1658

Merged
merged 3 commits into from
Nov 27, 2023

Commits on Nov 24, 2023

  1. feat: theme fontawesome icon size wrapped in spectrum icons

    Spectrum icons are 18px. However, our icons look best at 16px as they were designed on a 16px grid. This overrides the default spectrum icon size when wrapping a font-awesome icon inside a spectrum icon wrapper.
    
    Made overrides not a module, so it doesn't add hashes to the classes in overrides, as I have a feeling this file will be used to target specific classes and that wouldn't be desirable.
    
    Note: please suggest somewhere for that variable I added to live if you think that location sucks
    dsmmcken committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    8535174 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. update failing test

    dsmmcken committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fc7cf4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c2f742 View commit details
    Browse the repository at this point in the history