Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved preload variable handling #1723

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jan 10, 2024

  • Preload now always applies default preload values before applying cached ones. This ensures that cached preload values don't prevent new defaults from being applied if / when we add new variables to the preload list
  • Default preload variables can now be passed in to ThemeUtils + ThemeProvider. This will allow DHE to specify additional variables if needed

resolves #1695 and part of #1679

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3bea73) 46.44% compared to head (bad2545) 46.45%.

❗ Current head bad2545 differs from pull request most recent head ced4130. Consider uploading reports for the commit ced4130 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1723   +/-   ##
=======================================
  Coverage   46.44%   46.45%           
=======================================
  Files         611      611           
  Lines       37204    37209    +5     
  Branches     9363     9364    +1     
=======================================
+ Hits        17279    17284    +5     
  Misses      19871    19871           
  Partials       54       54           
Flag Coverage Δ
unit 46.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles requested a review from mofojed January 11, 2024 00:06
mofojed
mofojed previously approved these changes Jan 11, 2024
Comment on lines 47 to 50
function noop(): void {
// no-op
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the EMPTY_FUNCTION constant instead from @deephaven/utils.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I went ahead and updated

@bmingles bmingles merged commit ed41c42 into deephaven:main Jan 11, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@bmingles bmingles deleted the 1695-preload-theme-variable-fixes branch January 11, 2024 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming - merge default preload data into cached preload data
2 participants