Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-colorize command codeblocks when theme changes #1731

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Jan 16, 2024

Fixes an issues where the command history doesn't get re-colorized when the theme changes.

Steps to reproduce:
Run a command, then change theme (depends on which theme you started on, but history will look wrong):
image

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f919a7e) 46.48% compared to head (87855ad) 46.48%.

Files Patch % Lines
packages/console/src/common/Code.tsx 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   46.48%   46.48%   -0.01%     
==========================================
  Files         617      617              
  Lines       37288    37289       +1     
  Branches     9376     9378       +2     
==========================================
  Hits        17335    17335              
- Misses      19899    19900       +1     
  Partials       54       54              
Flag Coverage Δ
unit 46.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/console/src/common/Code.tsx Outdated Show resolved Hide resolved
@dsmmcken dsmmcken requested a review from mofojed January 16, 2024 22:18
@dsmmcken dsmmcken merged commit b1e42f5 into main Jan 16, 2024
5 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_theme_history branch January 16, 2024 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants