Make scrollbar styling consistent #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Sep 1, 2021
There was a problem hiding this comment.
I think you want the colours to be the same at least between native and grid? Right now they're all different, in the idle, hover, or dragging stage.
Also you can customize the monaco scroll bar a bit: https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.ieditorscrollbaroptions.html
and some colour options:
https://microsoft.github.io/monaco-editor/playground.html#customizing-the-appearence-exposed-colors
mofojed
approved these changes
Sep 3, 2021
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Sep 13, 2021
* `code-studio`, `console`, `file-explorer` * [deephaven#186](deephaven#186) Enable Scala syntax highlighting ([@nbauernfeind](https://github.com/nbauernfeind)) * `components`, `grid`, `iris-grid` * [deephaven#174](deephaven#174) Make scrollbar styling consistent ([@dsmmcken](https://github.com/dsmmcken)) * `console`, `iris-grid` * [deephaven#179](deephaven#179) Update monaco-editor to 0.27.0 ([@mofojed](https://github.com/mofojed)) * `code-studio` * [deephaven#187](deephaven#187) Fix proxy ([@mofojed](https://github.com/mofojed)) - Don ([@dsmmcken](https://github.com/dsmmcken)) - Mike Bender ([@mofojed](https://github.com/mofojed)) - Nate Bauernfeind ([@nbauernfeind](https://github.com/nbauernfeind))
Merged
mofojed
added a commit
that referenced
this pull request
Sep 13, 2021
* `code-studio`, `console`, `file-explorer` * [#186](#186) Enable Scala syntax highlighting ([@nbauernfeind](https://github.com/nbauernfeind)) * `components`, `grid`, `iris-grid` * [#174](#174) Make scrollbar styling consistent ([@dsmmcken](https://github.com/dsmmcken)) * `console`, `iris-grid` * [#179](#179) Update monaco-editor to 0.27.0 ([@mofojed](https://github.com/mofojed)) * `code-studio` * [#187](#187) Fix proxy ([@mofojed](https://github.com/mofojed)) - Don ([@dsmmcken](https://github.com/dsmmcken)) - Mike Bender ([@mofojed](https://github.com/mofojed)) - Nate Bauernfeind ([@nbauernfeind](https://github.com/nbauernfeind))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates scrollbars (monaco, grid, native) to all look similar. Since we can't control the monaco scrollbar styling, we instead match it. This style should look better for adding "selection-ticks to grid scrollbars" eventually anyways.
Monaco:
Native:
Grid:
(left: monaco, bottom-right: grid, top-right: native)