fix: DH-16463: isEqual returns false for layouts with undefined and missing props in panelState #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ops in panelState
vbabich
changed the title
vbabich
changed the title
mofojed
approved these changes
Feb 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1783 +/- ##
==========================================
+ Coverage 46.05% 46.07% +0.02%
==========================================
Files 628 628
Lines 37781 37781
Branches 9516 9516
==========================================
+ Hits 17401 17409 +8
+ Misses 20325 20317 -8
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutUtils.isEqualgives a false negative when we compare a dehydrated layout having any undefined property with the same layout passed throughJSON.serialize/JSON.parse, because all undefined properties get deleted when serialized.Fixes DH-16463