Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH-11336 support Layout Hints on web #208

Merged
merged 11 commits into from
Oct 15, 2021
Merged

DH-11336 support Layout Hints on web #208

merged 11 commits into from
Oct 15, 2021

Conversation

spasovski
Copy link
Contributor

This handles .hide(), .atFront() and .atEnd(). A separate ticket and PR will address .freeze().

@spasovski spasovski requested a review from mofojed September 22, 2021 20:50
@spasovski spasovski self-assigned this Sep 22, 2021
mofojed
mofojed requested changes Sep 23, 2021
View reviewed changes
@mofojed mofojed self-requested a review September 30, 2021 17:22
@spasovski spasovski requested a review from mofojed October 4, 2021 16:33
mofojed
mofojed requested changes Oct 5, 2021
View reviewed changes
@spasovski spasovski requested a review from mofojed October 6, 2021 15:24
@spasovski spasovski requested a review from mofojed October 8, 2021 15:18
mofojed
mofojed requested changes Oct 13, 2021
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the use of table.columns in PartitionSelectorSearch, AdvancedFilterCreatorSelectValue, and AdvancedFilterCreatorSelectValueList as well.

@spasovski spasovski requested a review from mofojed October 14, 2021 18:05
mofojed
mofojed requested changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the use of table.columns in PartitionSelectorSearch, AdvancedFilterCreatorSelectValue, and AdvancedFilterCreatorSelectValueList as well.

@spasovski
Copy link
Contributor Author

It seems we won't need to update the table.columns references in PartitionSelectorSearch, AdvancedFilterCreatorSelectValue, and AdvancedFilterCreatorSelectValueList since they are model.valuesTable. We could consider renaming table in these components however.

@spasovski spasovski requested a review from mofojed October 14, 2021 19:49
@spasovski spasovski merged commit c4f525a into deephaven:main Oct 15, 2021
@spasovski spasovski deleted the davor_DH-11336_ui branch October 15, 2021 20:52
@mattrunyon mattrunyon mentioned this pull request Oct 21, 2021
Merged
@mofojed mofojed mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@spasovski spasovski

Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spasovski @mofojed