feat: useSearchableViewportData - support non-text filters #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
changed the title
bmingles
force-pushed
the
2091-use-searchable-viewport-data-non-text
branch
from
6769152
to
6bc514b
Compare
mofojed
reviewed
Jun 27, 2024
| @@ -1825,6 +1887,11 @@ export class TableUtils { | |||
| dh.LongWrapper.ofString(TableUtils.removeCommas(value)) | |||
| ); | |||
| } | |||
| if (TableUtils.isDateType(type)) { | |||
| return dh.FilterValue.ofNumber( | |||
| DateUtils.trimDateTimeStringTimeZone(value) as unknown as number | |||
There was a problem hiding this comment.
Does this actually work? I wouldn't expect a date String to work being passed into ofNumber (just looking at the code).
There was a problem hiding this comment.
I think I had based this on the fact that this if check wasn't there before and the fallthrough case is just passing to dh.FilterValue.ofNumber. The code I added was simply to trim the date string and no longer strip commas
There was a problem hiding this comment.
hmm, Looks like maybe this function doesn't actually get called on Date columns which would explain why it works
There was a problem hiding this comment.
I removed that block of code since it's never actually hit
mofojed
approved these changes
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2091
BREAKING CHANGE:
useSearchableViewportDatato be more consistent withuseViewportData.usePickerWithSelectedValuesnow requirestimeZone.createSearchTextFilterrequirestimeZone