Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Read file separator from server config #2118

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Read file separator from server config #2118

wants to merge 5 commits into from

Commits on Jun 27, 2024

  1. WIP need to figure out why the tests are failing

    @mofojed
    mofojed committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0d60e18 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. WIP debuggin

    @mofojed
    mofojed committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2ca00f5 View commit details
    Browse the repository at this point in the history

  2. Fix up the tests 

    - Forgot to pass the separator in when creating a storage table
    @mofojed
    mofojed committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3af27a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. TODO: Need to fix the failing tests.

    @mofojed
    mofojed committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a3373aa View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Add the separator to all the file operations 

    - Added a context to pass down the FileStorage and file separator
- Cleaned up all the types and the tests
    @mofojed
    mofojed committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e69d64a View commit details
    Browse the repository at this point in the history