feat: Core plugins refactor, XComponent framework #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deephaven#1981) - Add XComponent (eXtendable Component) framework to allow components to be wrapped/replaced - Similar to Swizzling in Docusaurus - Useful for components that we need to replace at the Enterprise level (e.g. `WidgetPanelTooltip` needs to display the query name in Enterprise) - Pass a `VariableDescriptor` to `WidgetPanel` and `WidgetPanelTooltip` - Allows for more information to be included, e.g. a `QueryVariableDescriptor` which extends `VariableDescriptor` - Tested with branch `bender_DH-16263-core-plugins` on Enterprise
- Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety - Add xcomponents to the styleguide
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
==========================================
+ Coverage 46.62% 46.71% +0.08%
==========================================
Files 685 690 +5
Lines 38493 38527 +34
Branches 9589 9789 +200
==========================================
+ Hits 17948 17997 +49
+ Misses 20535 20520 -15
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattrunyon
previously approved these changes
Jul 17, 2024
- Fixes some issues on Enterprise where query or session information was dropped
mattrunyon
approved these changes
Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WidgetPanelTooltipneeds to display the query name in Enterprise)VariableDescriptortoWidgetPanelandWidgetPanelTooltipQueryVariableDescriptorwhich extendsVariableDescriptorPanelEvent.OPENeventPanelEvent.OPENPanelEvent.OPENdirectly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety