Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GridMetrics including totals rows in visible rows when scrolled to bottom #2194

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Aug 20, 2024

Noticed this while working on databars. The totals rows are being included in metrics.visibleRows when scrolled to the bottom. They were also being duplicated in allRows.

  1. Create a table such as t = empty_table(1000).update(["X=ii"])
  2. Add an aggregation
  3. Scroll to bottom of the table
  4. Log visibleRows or allRows from GridMetrics

Without this change you'll see that the totals row(s) (index 1000+) are included in those arrays when scrolled to the bottom. They are doubled in allRows

This doesn't seem to be the issue when aggregations are set to the top and the table is scrolled to the top.

@mattrunyon mattrunyon requested a review from mofojed August 20, 2024 05:41
@mattrunyon mattrunyon self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.65%. Comparing base (0b37477) to head (5fb5000).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2194   +/-   ##
=======================================
  Coverage   46.64%   46.65%           
=======================================
  Files         692      692           
  Lines       38581    38583    +2     
  Branches     9820     9845   +25     
=======================================
+ Hits        17998    18000    +2     
  Misses      20530    20530           
  Partials       53       53           
Flag Coverage Δ
unit 46.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit d409e96 into deephaven:main Aug 20, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@mattrunyon mattrunyon deleted the grid-visible-rows-fix branch August 27, 2024 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants