fix: GridMetrics including totals rows in visible rows when scrolled to bottom #2194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while working on databars. The totals rows are being included in
metrics.visibleRows
when scrolled to the bottom. They were also being duplicated inallRows
.t = empty_table(1000).update(["X=ii"])
visibleRows
orallRows
fromGridMetrics
Without this change you'll see that the totals row(s) (index 1000+) are included in those arrays when scrolled to the bottom. They are doubled in
allRows
This doesn't seem to be the issue when aggregations are set to the top and the table is scrolled to the top.