Fix card flip animation showing back-face in chrome #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabich
reviewed
Oct 12, 2021
packages/code-studio/src/controls/input-filter/InputFilter.scss
Outdated
Show resolved
Hide resolved
|
Extracted as component, also added some z-index and overflow shenanigan while animation is happening, because the perspective transform can actually trigger overflow, and z-index, so that it is always on top of other adjacent panels during flip animation. |
dsmmcken
changed the title
mofojed
requested changes
Oct 14, 2021
packages/dashboard-core-plugins/src/panels/InputFilterPanel.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Oct 14, 2021
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Oct 14, 2021
* [deephaven#232](deephaven#232) Fix notebook functionality ([@mofojed](https://github.com/mofojed)) * `code-studio`, `components`, `dashboard-core-plugins` * [deephaven#228](deephaven#228) Fix card flip animation showing back-face in chrome ([@dsmmcken](https://github.com/dsmmcken)) * `grid` * [deephaven#233](deephaven#233) Fix scroll bar not working in the corner if only one scroll direction ([@mofojed](https://github.com/mofojed)) * `dashboard-core-plugins` * [deephaven#230](deephaven#230) Fix up getTableMapForDashboard selector ([@mofojed](https://github.com/mofojed)) - Don ([@dsmmcken](https://github.com/dsmmcken)) - Mike Bender ([@mofojed](https://github.com/mofojed))
Merged
mofojed
added a commit
that referenced
this pull request
Oct 14, 2021
* [#232](#232) Fix notebook functionality ([@mofojed](https://github.com/mofojed)) * `code-studio`, `components`, `dashboard-core-plugins` * [#228](#228) Fix card flip animation showing back-face in chrome ([@dsmmcken](https://github.com/dsmmcken)) * `grid` * [#233](#233) Fix scroll bar not working in the corner if only one scroll direction ([@mofojed](https://github.com/mofojed)) * `dashboard-core-plugins` * [#230](#230) Fix up getTableMapForDashboard selector ([@mofojed](https://github.com/mofojed)) - Don ([@dsmmcken](https://github.com/dsmmcken)) - Mike Bender ([@mofojed](https://github.com/mofojed))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove react-card-flip component and replace with basic css, also reduce complexity of markup to make transforms cleaner. Card was showing as backwards when the front face was showing, but UI was short such that the backface had overflow scrolling. Probably a bug triggered by chrome, but reducing complexity solved it.
Also adds special logic to Button.tsx component, to handle tooltips on disabled buttons.
Fixes DH-11657