Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command history actions styling improvements #257

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Command history actions styling improvements #257

merged 1 commit into from
Oct 26, 2021

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Oct 26, 2021 •
edited
Loading

  • improved spacing when wrapped
  • clear selection on filter, as old selected range could be invalid
  • Actually use parent state for selection range, as a controlled component
  • use Button component for inline buttons (makes tooltips work when button disabled)
  • adjust icons on buttons to have mask, and arrow be above it

Before:
image

After:
image

@dsmmcken
Command history actions improvements
d46016e 
- improved spacing when wrapped
- clear selection on filter, as old selected range could be invalid
- use Button component for inline buttons
- adjust icons on buttons to have mask
@dsmmcken dsmmcken added the enhancement New feature or request label Oct 26, 2021
@dsmmcken dsmmcken requested a review from mofojed October 26, 2021 15:40
@dsmmcken dsmmcken self-assigned this Oct 26, 2021
@dsmmcken dsmmcken merged commit dc9df3e into main Oct 26, 2021
@dsmmcken dsmmcken deleted the dmckenzie_command-history-actions-fix branch October 26, 2021 16:35
@mofojed mofojed mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@dsmmcken dsmmcken

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmmcken @mofojed