Clean up dev/peer dependencies #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code studio bundle analysis w/ this change. Compare to that in the linked ticket
|
mattrunyon
force-pushed
the
mattrunyon_222
branch
from
03451af to
2c35578
Compare
mofojed
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222
Also removed any unused dependencies by packages and removed the gh-pages deploy scripts since we are not using gh-pages for anything.
@deephaven/logas a peer dependency because of LogProxy used for capturing all logs@deephaven/componentsis also a peer dependency because of theShortcutRegistry. This is a singleton which means it should be a peer dependency. Opened #264 to address this