Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to copy column header from ui #285

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Ability to copy column header from ui #285

merged 4 commits into from
Nov 11, 2021

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Nov 11, 2021

This is a small annoyance, but I would love to have "copy header" on the header right click menu.I can get it from the copying a selection with headers, but it would be nice to just copy the header.Just one. I'm copying it and using it a text. Either pasting into some Javascript code or putting it in an Excel Spreadsheet.

fixes DH-11843

Added to column menu and column tooltip.

@dsmmcken dsmmcken requested a review from mofojed November 11, 2021 15:10
@dsmmcken dsmmcken added the enhancement New feature or request label Nov 11, 2021
@mofojed
Copy link
Member

mofojed commented Nov 11, 2021

Should we allow copying the column type somehow as well? Text is currently not selectable in the column header:

image

mofojed
mofojed previously approved these changes Nov 11, 2021
packages/iris-grid/src/ColumnStatistics.jsx Outdated Show resolved Hide resolved
@dsmmcken
Copy link
Contributor Author

Should we allow copying the column type somehow as well? Text is currently not selectable in the column header:

No, I don't think that's something likely that you would need to do. I think we intentionally made it not selectable so when you double click that text you get just the name.

@dsmmcken dsmmcken requested a review from mofojed November 11, 2021 21:14
@dsmmcken dsmmcken merged commit 6a2eb64 into main Nov 11, 2021
@dsmmcken dsmmcken deleted the dmckenzie_DH-11843 branch November 11, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants