Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OHLC plots #291

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix OHLC plots #291

merged 1 commit into from
Nov 12, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Nov 12, 2021 •
edited
Loading

Tested using the steps in the bug

@mofojed
Fix OHLC plots
d722747 
- Was mapping the constant to the wrong value for the data
- Fixes deephaven#290
@mofojed mofojed added bug Something isn't working web-client-ui labels Nov 12, 2021
@mofojed mofojed added this to the November 2021 milestone Nov 12, 2021
@mofojed mofojed requested a review from spasovski November 12, 2021 15:31
@mofojed mofojed self-assigned this Nov 12, 2021
spasovski
spasovski approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@spasovski spasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mofojed mofojed merged commit 454d11b into deephaven:main Nov 12, 2021
@mofojed mofojed deleted the 290-ohlc branch November 12, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spasovski spasovski spasovski approved these changes

Assignees

@mofojed mofojed

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
November 2021
Development

Successfully merging this pull request may close these issues.

OHLC Plots Not Working
2 participants
@mofojed @spasovski