rerevert grid cleanup #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Nov 26, 2021
mofojed
commented
- Convert GridMetricCalculator, GridRange, GridUtils to TypeScript (Convert GridMetricCalculator, GridRange, GridUtils to TypeScript #302)
- Fix the calculation for visibleRowHeights/visibleColumnWidths
…phaven#302) - Convert part of grid to TypeScript - Add some JSDocs
Was screwing up the calculations still. Added a TODO ticket to clean it up and make it less confusing/prone to screwing up.
|
@mattrunyon @spasovski It would be easiest to review this just by looking at the second change. |
mofojed
commented
Nov 26, 2021
| state, | ||
| firstColumn, | ||
| treePaddingX | ||
| ); | ||
|
|
||
| // Calculate the metrics for the main grid | ||
| const visibleRows = Array.from(visibleRowHeights.keys()); |
There was a problem hiding this comment.
The problem was the visibleRows map was including floatingRows which is wrong. I have a ticket to make things make more sense, but I figure making it make more sense is a breaking change so leaving it in another change is safest.
mattrunyon
approved these changes
Nov 30, 2021
This was
linked to
issues
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.