Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the isolated linker #324

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Fix the isolated linker #324

merged 2 commits into from
Dec 3, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 2, 2021 •
edited
Loading

Was setting undefined but checking against null. Instead check against undefined.

@mofojed
Fix the isolated linker
f1542b9 
Was setting `undefined` but checking against `null`. Instead check against `undefined.
@mofojed mofojed added bug Something isn't working web-client-ui labels Dec 2, 2021
@mofojed mofojed added this to the December 2021 milestone Dec 2, 2021
@mofojed mofojed requested a review from vbabich December 2, 2021 16:28
@mofojed mofojed self-assigned this Dec 2, 2021
vbabich
vbabich requested changes Dec 2, 2021
View reviewed changes
Copy link
Collaborator

@vbabich vbabich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a couple of isolatedLinkerPanelId null checks in Linker.tsx left.

@mofojed mofojed requested a review from vbabich December 3, 2021 14:47
@mofojed mofojed merged commit d7fcd0b into deephaven:main Dec 3, 2021
@mofojed mofojed deleted the fix-isolated-linker branch December 3, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbabich vbabich vbabich approved these changes

Assignees

@mofojed mofojed

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
December 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @vbabich