Grid JS to TS conversion #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrunyon
requested changes
Dec 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
=========================================
+ Coverage 0 46.08% +46.08%
=========================================
Files 0 47 +47
Lines 0 7926 +7926
Branches 0 2121 +2121
=========================================
+ Hits 0 3653 +3653
- Misses 0 4026 +4026
- Partials 0 247 +247
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mattrunyon
requested changes
Dec 15, 2021
mattrunyon
requested changes
Dec 16, 2021
mattrunyon
previously approved these changes
Dec 17, 2021
Still need to do many other files and test it. GridRenderer still in progress.
Haven't tested anything
I don't know why it fails with npm start but doesn't show the error in VS Code. It seems like it should be fine, but it's not tracking the condition through multiple ifs/variables? Will check with Matt tomorrow.
Also made sure the x/y properties of EditOperation are just deprecated so we don't break existing plugins
It wasn't doing the same if check as above, so it was doing a context.restore without a previous context.save and screwing everything up. I don't know why unit tests complain about `column` or `row` possibly being null though, since VS Code doesn't complain and `isCursorVisible` already implies column/row are not null
- Moved delete from EditableGridModel to IrisGridModel. It deletes the ranges and shifts, which is functionality not accessible at all from Grid right now, so doesn't make sense to be in EditableGridModel. Will add a method to EditableGridModel when necessary, with a "shift" parameter as well to specify how to shift the data - Cleaned up some other docs
Some of the events we listen to are not wrapped in SyntheticEvent. Create these types to be the union of the native event and synthetic event, since it doesn't really matter which one we get - the properties we read are common to both.
- Remove extraneous assertions.ts file - Add try/catch around possible exception
|
Rebased, just need that +1 again |
spasovski
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpandableGridModel,EditableGridModel