Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cursor position marker in console input bar when scrollbar is hidden #335

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon added the enhancement New feature or request label Dec 7, 2021
@mattrunyon mattrunyon requested a review from mofojed December 7, 2021 21:39
@mattrunyon mattrunyon self-assigned this Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #335 (569bc48) into main (0df2de5) will increase coverage by 3.12%.
The diff coverage is 0.00%.

❗ Current head 569bc48 differs from pull request most recent head 6d7fd1b. Consider uploading reports for the commit 6d7fd1b to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##            main    #335      +/-   ##
========================================
+ Coverage   2.82%   5.94%   +3.12%     
========================================
  Files          2       2              
  Lines        780     202     -578     
  Branches     328      35     -293     
========================================
- Hits          22      12      -10     
+ Misses       631     190     -441     
+ Partials     127       0     -127     
Flag Coverage Δ
unit 5.94% <0.00%> (+3.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/console/src/ConsoleInput.jsx 4.52% <0.00%> (ø)
packages/iris-grid/src/CrossColumnSearch.jsx
packages/iris-grid/src/TableUtils.js
packages/console/src/StoragePropTypes.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df2de5...6d7fd1b. Read the comment docs.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing some artifacts when there's no overflow when on a line with parentheses:

image

@mattrunyon mattrunyon requested a review from mofojed December 7, 2021 22:16
@mattrunyon mattrunyon force-pushed the cursor-console-input branch from 569bc48 to d92f6f2 Compare December 7, 2021 23:15
@mattrunyon mattrunyon force-pushed the cursor-console-input branch from d92f6f2 to 6d7fd1b Compare December 7, 2021 23:30
@mofojed mofojed merged commit cdce34d into deephaven:main Dec 9, 2021
@mattrunyon mattrunyon deleted the cursor-console-input branch December 21, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants