Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of imports #346

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fix a couple of imports #346

merged 1 commit into from
Dec 10, 2021

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 9, 2021

  • VSCode likes to default to importing from the local index.ts file, which causes a circular import. This in turn breaks some mocks that requireActual. Fix up the imports to import directly from the file rather than from the index.

- VSCode likes to default to importing from the local index.ts file, which causes a circular import. This in turn breaks some mocks that `requireActual`. Fix up the imports to import directly from the file rather than from the index.
@mofojed mofojed requested a review from vbabich December 9, 2021 22:43
@mofojed mofojed self-assigned this Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #346 (02dddd2) into main (6a84aad) will increase coverage by 27.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #346       +/-   ##
=========================================
+ Coverage      0   27.05%   +27.05%     
=========================================
  Files         0        5        +5     
  Lines         0      573      +573     
  Branches      0      147      +147     
=========================================
+ Hits          0      155      +155     
- Misses        0      360      +360     
- Partials      0       58       +58     
Flag Coverage Δ
unit 27.05% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/dashboard/src/PanelManager.ts 48.61% <ø> (ø)
packages/dashboard/src/layout/LayoutUtils.js 6.10% <0.00%> (ø)
...mponents/src/context-actions/ContextActionUtils.ts 40.69% <0.00%> (ø)
...components/src/context-actions/ContextMenuRoot.tsx 65.21% <0.00%> (ø)
packages/dashboard/src/DashboardPlugin.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a84aad...02dddd2. Read the comment docs.

@mofojed mofojed merged commit 14c9ab6 into deephaven:main Dec 10, 2021
@mofojed mofojed deleted the fix-imports branch December 10, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants