Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Components Chunk 6 #63

Merged
merged 12 commits into from
Jun 9, 2021
Merged

TS Components Chunk 6 #63

merged 12 commits into from
Jun 9, 2021

Conversation

mattrunyon
Copy link
Collaborator

Closes #8
This is the final chunk of the conversion. Other merged PRs as part of the changes are #25 #29 #50 #56 and #57

Unit tests are still in JS. Switching them to TS causes several errors where the tests are using the components with some props missing. Those props are expected normally, but don't affect the test.

RadioItem
RadioGroup
SelectValueList
ToastNotification
UISwitch
SocketedButton
SingleClickItemList
ThemeExport
index file

@mattrunyon mattrunyon requested a review from mofojed June 8, 2021 23:44
@mattrunyon mattrunyon self-assigned this Jun 8, 2021
@mofojed mofojed merged commit ee5a72d into main Jun 9, 2021
@mofojed mofojed deleted the ts-components-chunk-6 branch June 9, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert @deephaven/components to TS
2 participants