Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload SetupTool #1

Closed
wants to merge 11 commits into from

Conversation

kunluntech-ci
Copy link

This tool is used to view and modify BIOS Setup options in the OS

@deepin-ci-robot
Copy link

Hi @kunluntech-ci. Thanks for your PR. 😃

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xzl01 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @kunluntech-ci. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@UTsweetyfish
Copy link

/hold

Copy link

github-actions bot commented May 29, 2024

TAG Bot

TAG: 1.5.25
EXISTED: no
DISTRIBUTION: beige

Copy link

@UTsweetyfish UTsweetyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepin-community下不允许二进制上传。请要么按照应用商店的上传方式,直接在应用商店投递二进制deb包;要么将源码投递到仓库下,使用自动构建。

Copy link

@UTsweetyfish UTsweetyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 明确软件包名,建议包名中至少带 kunlun 或类似字样
  2. 由于目前无法上架商店,如果想二进制上传到 commercial 仓库的话,则不应再安装到 /opt/apps/ 下,可以直接打包到 /usr/ 中
  3. patchelf 为什么要自己带一份?
  4. start.sh 是做什么的?
  5. debian/postinst 应带 shebang
  6. debian/postinst 不应设置 777
  7. 如果不安装到 /opt/apps/ 下,则可以直接将 .desktop 安装到 /usr/share/applications/,而不应使用 cp
  8. 不应复制 .desktop 到 /home/$HomeDir/Desktop/
  9. debian/ 目录下其他文件也应规范编写

2、按照要求修改debian文件
3、更新README
2、安装到/usr/libexec/com.kunluntech.SetupTool/目录下
@kunluntech-ci
Copy link
Author

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1530
PrNumber: 1530
PrBranch: auto-integration-9315412235

@kunluntech-ci
Copy link
Author

/integrate

@UTsweetyfish
Copy link

UTsweetyfish commented Jun 5, 2024

已集成( linuxdeepin/developer-center#8867 ),关闭此 PR 以防止重新集成。

新 bug 单: linuxdeepin/developer-center#8914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants