-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload SetupTool #1
Conversation
Hi @kunluntech-ci. Thanks for your PR. 😃 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kunluntech-ci. Thanks for your PR. I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
TAG Bot TAG: 1.5.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin-community下不允许二进制上传。请要么按照应用商店的上传方式,直接在应用商店投递二进制deb包;要么将源码投递到仓库下,使用自动构建。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 明确软件包名,建议包名中至少带 kunlun 或类似字样
- 由于目前无法上架商店,如果想二进制上传到 commercial 仓库的话,则不应再安装到 /opt/apps/ 下,可以直接打包到 /usr/ 中
- patchelf 为什么要自己带一份?
- start.sh 是做什么的?
- debian/postinst 应带 shebang
- debian/postinst 不应设置 777
- 如果不安装到 /opt/apps/ 下,则可以直接将 .desktop 安装到 /usr/share/applications/,而不应使用 cp
- 不应复制 .desktop 到 /home/$HomeDir/Desktop/
- debian/ 目录下其他文件也应规范编写
/integrate |
AutoIntegrationPr Bot |
/integrate |
已集成( linuxdeepin/developer-center#8867 ),关闭此 PR 以防止重新集成。 新 bug 单: linuxdeepin/developer-center#8914 |
This tool is used to view and modify BIOS Setup options in the OS