Skip to content

Commit

Permalink
ksmbd: don't update ->op_state as OPLOCK_STATE_NONE on error
Browse files Browse the repository at this point in the history
ksmbd set ->op_state as OPLOCK_STATE_NONE on lease break ack error.
op_state of lease should not be updated because client can send lease
break ack again. This patch fix smb2.lease.breaking2 test failure.

Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
  • Loading branch information
namjaejeon authored and Steve French committed Nov 24, 2023
1 parent 9ac45ac commit cd80ce7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/smb/server/smb2pdu.c
Original file line number Diff line number Diff line change
Expand Up @@ -8234,7 +8234,6 @@ static void smb21_lease_break_ack(struct ksmbd_work *work)
return;

err_out:
opinfo->op_state = OPLOCK_STATE_NONE;
wake_up_interruptible_all(&opinfo->oplock_q);
atomic_dec(&opinfo->breaking_cnt);
wake_up_interruptible_all(&opinfo->oplock_brk);
Expand Down

0 comments on commit cd80ce7

Please sign in to comment.