[doc] Fix broken link in jupyter readme #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ You can open the `http://localhost:8888` to see the hosted instance on docker. | |||
|
|
|||
| ### Build docker image by yourself | |||
|
|
|||
| You can read [Dockerfile](https://docs.djl.ai/docs/demos/jupyter/Dockerfile) for detail. To build docker image: | |||
There was a problem hiding this comment.
Is this removed from docs.djl.ai?
There was a problem hiding this comment.
Yes, customer reported this issue.
There was a problem hiding this comment.
Should we add it back? Or just update the link
There was a problem hiding this comment.
Maybe we should add it back in the docs. Not sure, why it got removed.
There was a problem hiding this comment.
the Dockerfile is excluded here: https://github.com/deepjavalibrary/djl/blob/master/docs/mkdocs.yml#L55
We can add it back if want to. But pointing to github source isn't a bad idea.
sindhuvahinis
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.