Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows load ModelZoo model using url #1120

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I2727d6fef2675f3f417d35322244dd1228b3816b

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu force-pushed the repo branch 2 times, most recently from 6c5e98a to 4042524 Compare July 23, 2021 07:16
@codecov-commenter
Copy link

Codecov Report

Merging #1120 (4042524) into master (154ae6e) will increase coverage by 0.05%.
The diff coverage is 79.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1120      +/-   ##
============================================
+ Coverage     70.03%   70.08%   +0.05%     
- Complexity     5278     5279       +1     
============================================
  Files           513      513              
  Lines         23497    23525      +28     
  Branches       2516     2517       +1     
============================================
+ Hits          16456    16488      +32     
+ Misses         5703     5697       -6     
- Partials       1338     1340       +2     
Impacted Files Coverage Δ
...ain/java/ai/djl/repository/AbstractRepository.java 76.59% <0.00%> (ø)
.../src/main/java/ai/djl/repository/VersionRange.java 18.18% <0.00%> (-0.43%) ⬇️
...pi/src/main/java/ai/djl/repository/Repository.java 81.81% <50.00%> (ø)
...in/java/ai/djl/repository/zoo/BaseModelLoader.java 79.66% <66.66%> (-0.69%) ⬇️
.../java/ai/djl/repository/RepositoryFactoryImpl.java 80.00% <71.83%> (+3.25%) ⬆️
.../main/java/ai/djl/repository/RemoteRepository.java 89.13% <80.00%> (-1.12%) ⬇️
...in/java/ai/djl/repository/zoo/DefaultModelZoo.java 92.30% <90.47%> (-7.70%) ⬇️
.../src/main/java/ai/djl/repository/zoo/ModelZoo.java 80.00% <91.66%> (+26.00%) ⬆️
.../src/main/java/ai/djl/repository/zoo/Criteria.java 84.65% <100.00%> (-0.51%) ⬇️
...java/ai/djl/repository/zoo/DefaultZooProvider.java 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154ae6e...4042524. Read the comment docs.

@frankfliu frankfliu force-pushed the repo branch 2 times, most recently from 01a9488 to 3cccfd8 Compare July 30, 2021 20:25
Change-Id: I2727d6fef2675f3f417d35322244dd1228b3816b
@frankfliu frankfliu merged commit d36d6d2 into deepjavalibrary:master Aug 2, 2021
@frankfliu frankfliu deleted the repo branch August 2, 2021 19:56
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Co-authored-by: KexinFeng <fenkexin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants