Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repository implemenation #1139

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

frankfliu
Copy link
Contributor

  1. allows pass arguments from url query string
  2. Move some logic from RepositoryFactory into AbstractRepository.

Change-Id: If8f1821bf556c96f522810f45a13cb42d98f0ab4

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

1. allows pass arguments from url query string
2. Move some logic from RepositoryFactory into AbstractRepository.

Change-Id: If8f1821bf556c96f522810f45a13cb42d98f0ab4
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #1139 (210efd2) into master (d36d6d2) will decrease coverage by 0.06%.
The diff coverage is 88.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1139      +/-   ##
============================================
- Coverage     70.14%   70.08%   -0.07%     
+ Complexity     5327     5314      -13     
============================================
  Files           513      513              
  Lines         23687    23657      -30     
  Branches       2542     2541       -1     
============================================
- Hits          16616    16580      -36     
- Misses         5716     5717       +1     
- Partials       1355     1360       +5     
Impacted Files Coverage Δ
...src/main/java/ai/djl/repository/JarRepository.java 86.66% <80.00%> (-1.97%) ⬇️
.../java/ai/djl/repository/RepositoryFactoryImpl.java 77.22% <80.00%> (-3.29%) ⬇️
...in/java/ai/djl/repository/SimpleUrlRepository.java 70.49% <80.00%> (-1.18%) ⬇️
...ain/java/ai/djl/repository/AbstractRepository.java 76.87% <80.95%> (+0.27%) ⬆️
...s-ai/src/main/java/ai/djl/aws/s3/S3Repository.java 91.20% <88.00%> (+0.06%) ⬆️
...c/main/java/ai/djl/hadoop/hdfs/HdfsRepository.java 86.81% <92.00%> (-0.20%) ⬇️
api/src/main/java/ai/djl/repository/Artifact.java 86.17% <100.00%> (-3.83%) ⬇️
...c/main/java/ai/djl/repository/LocalRepository.java 71.11% <100.00%> (+0.27%) ⬆️
api/src/main/java/ai/djl/repository/Metadata.java 86.56% <100.00%> (+0.20%) ⬆️
.../main/java/ai/djl/repository/RemoteRepository.java 88.09% <100.00%> (-1.04%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36d6d2...210efd2. Read the comment docs.

@frankfliu frankfliu requested review from zachgk, stu1130 and lanking520 and removed request for zachgk August 3, 2021 05:59
@frankfliu frankfliu merged commit eea8c6c into deepjavalibrary:master Aug 6, 2021
@frankfliu frankfliu deleted the repo branch August 6, 2021 00:55
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants