[djl-bench] Run benchmark on multiple GPUs #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1144 +/- ##
============================================
- Coverage 70.12% 70.10% -0.02%
Complexity 5329 5329
============================================
Files 513 513
Lines 23696 23725 +29
Branches 2545 2552 +7
============================================
+ Hits 16617 16633 +16
- Misses 5722 5728 +6
- Partials 1357 1364 +7
Continue to review full report at Codecov.
|
zachgk
reviewed
Aug 4, 2021
| List<PredictorCallable> callables = new ArrayList<>(numOfThreads); | ||
| for (int i = 0; i < numOfThreads; ++i) { | ||
| callables.add(new PredictorCallable(model, metrics, counter, i, i == 0)); | ||
| for (Device device : devices) { |
There was a problem hiding this comment.
This means that the number of threads is really the number of threads per GPU. Is this the behavior users would expect? Should we document this somewhere or change some names to make it clearer?
There was a problem hiding this comment.
number of threads per GPU is confusing, I change it to total thread and added error checking,
I also changed number of iteration in the same way.
Change-Id: Ie27e090699695526df42fefd01db2aba78dc3f73
zachgk
approved these changes
Aug 5, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/djl
that referenced
this pull request
Oct 10, 2023
Co-authored-by: KexinFeng <fenkexin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie27e090699695526df42fefd01db2aba78dc3f73
Description
Brief description of what this PR is about