Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[djl-bench] remove artificat_id and criteria arguments in favor of using djl:// url #1146

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

frankfliu
Copy link
Contributor

Change-Id: I222f75fad4c14e470fa0a92c9d1d61ffc729f697

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #1146 (0dd8447) into master (eea8c6c) will increase coverage by 0.11%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1146      +/-   ##
============================================
+ Coverage     70.11%   70.23%   +0.11%     
- Complexity     5323     5337      +14     
============================================
  Files           513      513              
  Lines         23689    23664      -25     
  Branches       2553     2551       -2     
============================================
+ Hits          16610    16620      +10     
+ Misses         5711     5683      -28     
+ Partials       1368     1361       -7     
Impacted Files Coverage Δ
...mark/src/main/java/ai/djl/benchmark/Arguments.java 95.23% <83.33%> (+17.86%) ⬆️
.../main/java/ai/djl/benchmark/AbstractBenchmark.java 91.32% <100.00%> (+0.98%) ⬆️
.../src/main/java/ai/djl/repository/zoo/Criteria.java 82.38% <0.00%> (-3.41%) ⬇️
.../java/ai/djl/benchmark/MultithreadedBenchmark.java 75.30% <0.00%> (+4.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea8c6c...0dd8447. Read the comment docs.

…ing djl:// url

Change-Id: I222f75fad4c14e470fa0a92c9d1d61ffc729f697
@frankfliu frankfliu merged commit 2cc65c1 into deepjavalibrary:master Aug 6, 2021
@frankfliu frankfliu deleted the benchmark branch August 6, 2021 22:32
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Co-authored-by: KexinFeng <fenkexin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants