[spark] Integrate HuggingFace tokenizer #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyang16
changed the title
Codecov ReportBase: 72.08% // Head: 74.14% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2311 +/- ##
============================================
+ Coverage 72.08% 74.14% +2.05%
- Complexity 5126 6788 +1662
============================================
Files 473 667 +194
Lines 21970 29566 +7596
Branches 2351 3057 +706
============================================
+ Hits 15838 21921 +6083
- Misses 4925 6160 +1235
- Partials 1207 1485 +278
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lanking520
reviewed
Jan 10, 2023
xyang16
changed the title
frankfliu
reviewed
Jan 29, 2023
| * [[TokenizerFactory]] contains tokenizer creation mechanism on top of different platforms. | ||
| * System will choose appropriate Factory based on the supported audio type. | ||
| */ | ||
| class TokenizerFactory { |
There was a problem hiding this comment.
Should we add TokenizerFactory in our api package?
There was a problem hiding this comment.
Maybe leave it here for now and refactor later
lanking520
approved these changes
Feb 8, 2023
xyang16
force-pushed
the
tokenizer
branch
9 times, most recently
from
b0344f9 to
da2c473
Compare
xyang16
changed the title
xyang16
force-pushed
the
tokenizer
branch
4 times, most recently
from
f400040 to
d779b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Add HuggingFace tokenizer in Spark extension