[api] Use folk java process to avoid jvm consume GPU memory #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyang16
reviewed
Dec 2, 2023
| return; | ||
| } | ||
| int cudaVersion = getCudaVersion(); | ||
| System.out.println(gpuCount + "," + cudaVersion); |
There was a problem hiding this comment.
We need to read the console output from java side
zachgk
reviewed
Dec 2, 2023
| try { | ||
| testCudaUtils(); | ||
| } finally { | ||
| System.clearProperty("ai.djl.util.folk_cuda_utils"); |
There was a problem hiding this comment.
Suggested change
| System.clearProperty("ai.djl.util.folk_cuda_utils"); | |
| System.clearProperty("ai.djl.util.cuda.folk"); |
| @@ -50,6 +54,11 @@ public static boolean hasCuda() { | |||
| * @return the number of GPUs available in the system | |||
| */ | |||
| public static int getGpuCount() { | |||
| if (Boolean.getBoolean("ai.djl.util.cuda.folk")) { | |||
| String[] ret = execute(-1); | |||
There was a problem hiding this comment.
Can we cache the result of execute?
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2882 +/- ##
============================================
+ Coverage 72.08% 72.28% +0.19%
- Complexity 5126 7177 +2051
============================================
Files 473 708 +235
Lines 21970 31988 +10018
Branches 2351 3332 +981
============================================
+ Hits 15838 23121 +7283
- Misses 4925 7276 +2351
- Partials 1207 1591 +384 ☔ View full report in Codecov by Sentry. |
xyang16
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about