Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous OSX to 13 #3004

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Update continuous OSX to 13 #3004

merged 2 commits into from
Feb 22, 2024

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Feb 22, 2024

This is to fix the flaky llama engine segfaults on CI.

This is to fix the flaky llama engine segfaults on CI.
@zachgk zachgk requested review from frankfliu and a team as code owners February 22, 2024 19:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.20%. Comparing base (92f2d84) to head (c9c998f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3004      +/-   ##
============================================
- Coverage     72.30%   72.20%   -0.10%     
+ Complexity     7293     7286       -7     
============================================
  Files           722      722              
  Lines         32525    32525              
  Branches       3395     3395              
============================================
- Hits          23517    23486      -31     
- Misses         7384     7418      +34     
+ Partials       1624     1621       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu
Copy link
Contributor

I think we need to brew install libomp for mac13

@zachgk zachgk merged commit 7959c27 into deepjavalibrary:master Feb 22, 2024
5 checks passed
@zachgk zachgk deleted the upCiOsx branch February 22, 2024 22:45
frankfliu pushed a commit that referenced this pull request Apr 26, 2024
* Update continuous OSX to 13

This is to fix the flaky llama engine segfaults on CI.

* Add libomp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants