[tokenizer] add optional tokenizerPath Prior to modelPath #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We actually only need make changes to HuggingfaceTokenizer.builder(), the arguments in criteria will override .optTokenizerPath(). |
frankfliu
approved these changes
Apr 24, 2024
frankfliu
added a commit
that referenced
this pull request
Apr 26, 2024
* [tokenizer] add optional tokenizerPath Prior to modelPath --------- Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our actual usage, there are scenarios where
tokenizerPathandmodelPathdiffer. In theTranslatorFactory, we check if thetokenizerPathfield is set, which has a higher priority thanmodelPath. IftokenizerPathis not configured,modelPathwill be used by default, ensuring no impact on existing code.