Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fixes IdEmbedding memory leak #3257

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

frankfliu
Copy link
Contributor

Fixes: #3251

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners June 16, 2024 21:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (bd7f4ca) to head (6beb95c).
Report is 12 commits behind head on master.

Files Patch % Lines
...c/main/java/ai/djl/nn/transformer/IdEmbedding.java 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3257      +/-   ##
============================================
+ Coverage     64.26%   72.42%   +8.16%     
- Complexity     6455     7328     +873     
============================================
  Files           676      677       +1     
  Lines         32443    32512      +69     
  Branches       3417     3430      +13     
============================================
+ Hits          20849    23547    +2698     
+ Misses        10016     7350    -2666     
- Partials       1578     1615      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit bb7dfd1 into deepjavalibrary:master Jun 17, 2024
5 checks passed
@frankfliu frankfliu deleted the leak branch June 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ai.djl.nn.transformer IdEmbedding has memory leak.
3 participants