-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-side streaming thrown errors are not propagating to client #607
Comments
It seems very likely to me to be caused by grpc-js 1.10. The failing tests catch this situation here: https://github.com/deeplay-io/nice-grpc/actions/runs/9346639886/job/25721924757#step:7:573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using nice-grpc and/or nice-grpc-web as both the client and server:
with grpc-js pinned to 1.10.6 - which is admittedly not known to be supported (#555). the bug could be related to this.
trimmed example:
I've observed that the server does log the
okok
but silently does nothing on the throw. The client will async iterate on server responses, and if any are sent it will receive them up until the throw. Once a server throw occurs, it seems like the client neither gets acatch
norfinally
. Just hangs.The text was updated successfully, but these errors were encountered: