Skip to content

Refactor: move rho_mag from Charge into Charge_Mixing, making them independent of each other #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 5, 2024
Merged

Refactor: move rho_mag from Charge into Charge_Mixing, making them independent of each other #3435

merged 9 commits into from
Jan 5, 2024

Conversation

@WHUweiqingzhou
Copy link
Collaborator

Fix #3434 and #3363. After this PR, Charge_Mixing does not require the definition of functions of Charge.

Lists of Changes

  1. delete the code about rho_mag and rhog_mag in Charge, and add them into Charge_Mixing.
  2. delete the mocks about rho_mag and rhog_mag in Charge_Mixing_Test.
  3. move renormalize_rho() outside Charge_Mixing

dyzheng
dyzheng approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor.

@dyzheng dyzheng merged commit e6d6df4 into deepmodeling:develop Jan 5, 2024
@WHUweiqingzhou WHUweiqingzhou deleted the refactor_mixing_nspin2 branch January 5, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyzheng dyzheng dyzheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bugs: possible memory leak of MixRhoTest

2 participants

@WHUweiqingzhou @dyzheng