Skip to content

Fix: Fix memory leak introduced by new gint module #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Fix: Fix memory leak introduced by new gint module #6375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9dc606
fix memory leak
dzzz2001 Jul 10, 2025
f68acad
delete copy assignment
dzzz2001 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source/source_lcao/module_hcontainer/hcontainer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ HContainer<T>::HContainer(HContainer<T>&& HR_in) noexcept
this->wrapper_pointer = HR_in.wrapper_pointer;
this->gamma_only = HR_in.gamma_only;
this->paraV = HR_in.paraV;
this->allocated = HR_in.allocated;
this->current_R = -1;
HR_in.wrapper_pointer = nullptr;
// tmp terms not moved
Expand All @@ -63,6 +64,7 @@ HContainer<T>& HContainer<T>::operator=(HContainer<T>&& HR_in) noexcept
this->wrapper_pointer = HR_in.wrapper_pointer;
this->gamma_only = HR_in.gamma_only;
this->paraV = HR_in.paraV;
this->allocated = HR_in.allocated;
this->current_R = -1;

HR_in.wrapper_pointer = nullptr;
Expand Down
5 changes: 4 additions & 1 deletion source/source_lcao/module_hcontainer/hcontainer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,10 @@ class HContainer
* data of HR_in will not be copied, please call add() after this constructor to copy data.
*/
HContainer(const HContainer<T>& HR_in, T* data_array = nullptr);


// copy assignment, not allowed
HContainer& operator=(const HContainer<T>& HR_in) = delete;

// move constructor
HContainer(HContainer<T>&& HR_in) noexcept;
// move assignment
Expand Down
Loading