Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set allow_growth in default_tf_session_config #1067

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 30, 2021

Currently, TF only initializes GPUs once, and never releases memory. As a result, we must set allow_growth in the first Session (or every session?), otherwise it doesn't work.

Please confirm the allow_growth config in trainer.py is expected, otherwise we should remove it instead.

config.gpu_options.allow_growth = True

Currently, TF only initializes GPUs once, and never releases memory. As a result, we must set `allow_growth` in the first Session (or every session?), otherwise it doesn't work.

Please confirm the `allow_growth` config in `trainer.py` is expected, otherwise we should remove it instead.
@njzjz
Copy link
Member Author

njzjz commented Aug 30, 2021

ping @shishaochen

@codecov-commenter
Copy link

Codecov Report

Merging #1067 (8930772) into devel (8dbc211) will decrease coverage by 10.88%.
The diff coverage is n/a.

❗ Current head 8930772 differs from pull request most recent head 30ae6e0. Consider uploading reports for the commit 30ae6e0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1067       +/-   ##
===========================================
- Coverage   75.16%   64.28%   -10.89%     
===========================================
  Files          87        5       -82     
  Lines        6959       14     -6945     
===========================================
- Hits         5231        9     -5222     
+ Misses       1728        5     -1723     
Impacted Files Coverage Δ
deepmd/utils/learning_rate.py
deepmd/descriptor/hybrid.py
deepmd/infer/deep_polar.py
deepmd/model/model_stat.py
source/op/_prod_force_se_r_grad.py
deepmd/entrypoints/freeze.py
deepmd/infer/__init__.py
source/op/_tabulate_grad.py
deepmd/utils/tabulate.py
deepmd/calculator.py
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbc211...30ae6e0. Read the comment docs.

@njzjz njzjz requested a review from denghuilu August 30, 2021 18:24
@amcadmus amcadmus merged commit 4c10232 into deepmodeling:devel Aug 31, 2021
@njzjz njzjz deleted the allow_growth branch August 31, 2021 02:40
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants