Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Call to method DeepTensor.__init__ with too many arguments" #1125

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 10, 2021

As detected by LGTM, here is an error:
Call to method DeepTensor.init with too many arguments; should be no more than 4.

I agree with the automatic code analysis tool.

As detected by LGTM, here is an error:
Call to method DeepTensor.__init__ with too many arguments; should be no more than 4.

I agree with the automatic code analysis tool.
@njzjz njzjz requested a review from amcadmus September 10, 2021 06:36
@codecov-commenter
Copy link

Codecov Report

Merging #1125 (124b97e) into devel (5ab5fa1) will decrease coverage by 10.81%.
The diff coverage is n/a.

❗ Current head 124b97e differs from pull request most recent head 14ea8d5. Consider uploading reports for the commit 14ea8d5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1125       +/-   ##
===========================================
- Coverage   75.10%   64.28%   -10.82%     
===========================================
  Files          87        5       -82     
  Lines        6953       14     -6939     
===========================================
- Hits         5222        9     -5213     
+ Misses       1731        5     -1726     
Impacted Files Coverage Δ
deepmd/calculator.py
deepmd/infer/deep_pot.py
deepmd/op/__init__.py
deepmd/infer/deep_wfc.py
deepmd/utils/data.py
deepmd/utils/convert.py
deepmd/descriptor/se_a_ebd.py
deepmd/fit/dipole.py
deepmd/model/model_stat.py
deepmd/fit/wfc.py
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab5fa1...14ea8d5. Read the comment docs.

Copy link
Member

@amcadmus amcadmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the class DeepGlobalPolar is not used by deepmd-kit anymore.

@amcadmus amcadmus merged commit e263aa3 into deepmodeling:devel Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants