-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calculate neighbor statistics from CLI #1476
Conversation
In many cases, we need to confirm neighbor statistics before training. This command provides such CLI option.
Codecov Report
@@ Coverage Diff @@
## devel #1476 +/- ##
===========================================
- Coverage 75.68% 64.28% -11.41%
===========================================
Files 92 5 -87
Lines 7671 14 -7657
===========================================
- Hits 5806 9 -5797
+ Misses 1865 5 -1860 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please:
- add to the document showing how it works.
- add a unittest for
neighbor_stat
Thanks!
# set rcut to 0. will cause a core dumped | ||
# TODO: check what is wrong | ||
for rcut in (3., 6., 11.): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denghuilu setting rcut
to 0.
will cause "core dumped". Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Although, I don't think some one will set it to 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be caused by this line:
deepmd-kit/source/lib/src/neighbor_list.cc
Line 665 in 159e45d
ncell[dd] = to_face[dd] / rc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In many cases, we need to confirm neighbor statistics before training.
This command provides such CLI option.