Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to detect model version #2318

Merged
merged 35 commits into from
Feb 17, 2023

Conversation

Yi-FanLi
Copy link
Collaborator

This PR adds a script in deepmd/utils to detect the version of a Deep Potential model.

@Yi-FanLi Yi-FanLi requested a review from njzjz February 14, 2023 18:54
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 74.80% // Head: 74.78% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9fb63aa) compared to base (c53a1e1).
Patch coverage: 67.92% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2318      +/-   ##
==========================================
- Coverage   74.80%   74.78%   -0.02%     
==========================================
  Files         223      223              
  Lines       22200    22252      +52     
  Branches     1627     1627              
==========================================
+ Hits        16606    16641      +35     
- Misses       4539     4556      +17     
  Partials     1055     1055              
Impacted Files Coverage Δ
deepmd/entrypoints/main.py 91.47% <ø> (ø)
deepmd/utils/convert.py 70.44% <66.00%> (-2.04%) ⬇️
deepmd/entrypoints/convert.py 70.58% <100.00%> (+3.92%) ⬆️
source/lib/src/fmt_nlist.cc 79.26% <0.00%> (-1.22%) ⬇️
source/lib/include/ComputeDescriptor.h 79.13% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test can be added here

convert_pbtxt_to_pb(str(tests_path / "infer" / "sea_012.pbtxt"), old_model)
run_dp(f"dp convert-from 0.12 -i {old_model} -o {new_model}")

@Yi-FanLi Yi-FanLi requested a review from njzjz February 16, 2023 04:40
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njzjz
Copy link
Member

njzjz commented Feb 16, 2023

please fix the pre-commit error

@Yi-FanLi
Copy link
Collaborator Author

please fix the pre-commit error

Yes. Now I have fixed it.

@wanghan-iapcm wanghan-iapcm merged commit 445f6ba into deepmodeling:devel Feb 17, 2023
dingye18 added a commit to dingye18/deepmd-kit that referenced this pull request Feb 17, 2023
* print MAE for `dp test` (deepmodeling#2310)

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix bug deepmodeling#2311 when using FP32 in se_atten (deepmodeling#2312)

Fix bug deepmodeling#2311 when using FP32 in se_atten

* support multiple frames DeepPot in C/hpp API (deepmodeling#2309)

* Add DeepPot C API v2 to support multiple frames. Also, preserve the
arguments for fparam and aparam for future use (planned in deepmodeling#2236). V1 is
kept for API and ABI compatibility.
* Support multiple frames for DeepPot hpp API. The API compatibility is
kept. Add tests for new situation.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

* Implementation of se_a_mask op (deepmodeling#2313)

* Implement se_a_mask op. Training and inference (c++ interface) are
tested. Unit test files are required.

* Fix bug in atom pref setting for forces.

* Add the unit test for descrpt se_a_mask

* Remove the unit test for dp mask model

* Update dp mask system path for unit test

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* support exclude_types for se_atten (deepmodeling#2315)

Fix deepmodeling#2232.

Also, clean old useless codes for `exclude_types`.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

* fix restarting from the original model (deepmodeling#2317)

deepmodeling#2253 supports restarting from the compressed model but breaks the
original model. This PR fixes the error by detecting the model type
first.

```
FAILED_PRECONDITION: Attempting to use uninitialized value
```

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

* package dp_ipi in the PyPI wheels (deepmodeling#2320)

Fix deepmodeling#2282.

In addition, change the return code of `dp_ipi` (without any arguments)
from 1 to 0.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* build Docker images for each push (deepmodeling#2324)

and push the image to the GitHub container.

Also, provide the pypi CUDA support for pypi LAMMPS.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

* Fix typo in install docs (deepmodeling#2325)

Signed-off-by: Chun Cai <amoycaic@gmail.com>

* Add a script to detect model version (deepmodeling#2318)

This PR adds a script in deepmd/utils to detect the version of a Deep
Potential model.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Chun Cai <amoycaic@gmail.com>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Duo <50307526+iProzd@users.noreply.github.com>
Co-authored-by: Chun Cai <amoycaic@gmail.com>
Co-authored-by: Yifan Li李一帆 <yifanl0716@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants